Add terminate profile and scheduled events profile to Microsoft.Compute by szimmer-dev · Pull Request #6683 · Azure/azure-rest-api-specs

szimmer-dev · 2019-07-20T00:47:51Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…e Microosft.Compute autorest config.

openapi-sdkautomation · 2019-07-20T00:47:54Z

SDK Automation [Logs] (Generated from 84963d0, Iteration 12)

Python: Azure/azure-sdk-for-python [Logs]

No packages generated.

Java: Azure/azure-sdk-for-java [Logs] [Diff]

compute/resource-manager/v2017_03_30 [Logs]
compute/resource-manager/v2017_09_01 [Logs] [Instructions]
compute/resource-manager/v2017_12_01 [Logs]
compute/resource-manager/v2018_04_01 [Logs] [Instructions]

JavaScript: Azure/azure-sdk-for-js [Logs]

No packages generated.

Go: test-repo-billy/azure-sdk-for-go [Logs]

No packages generated.

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-07-20T00:51:01Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6461

AutorestCI · 2019-07-20T00:55:02Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5409

AutorestCI · 2019-07-20T00:55:03Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2019-07-20T02:01:26Z

Can one of the admins verify this patch?

nschonni

Looks like there was a character encoding issue

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

…e/2019-03-01/compute.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…nstance view expansion to get VM Scale Set VM.

amarzavery

Please provide new examples or update existing examples with the new properties/models being added in this PR.

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

… scheudled events and termiante profile schemas.

szimmer-dev · 2019-07-31T19:39:56Z

update

Example was added as requested.

hyonholee · 2019-07-31T22:53:36Z

LGTM

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

majastrz

I added some questions to the PR. Can you take a look?

majastrz

Signed off from ARM side.

szimmer-dev added 2 commits July 19, 2019 16:42

Add terminate notification profile and scheduled events profile to th…

24bcc42

…e Microosft.Compute autorest config.

Correct definition format

9bb1d5b

szimmer-dev requested review from huangpf and hyonholee as code owners July 20, 2019 00:47

AutorestCI mentioned this pull request Jul 20, 2019

[AutoPR compute/resource-manager] Add terminate profile and scheduled events profile to Microsoft.Compute Azure/azure-sdk-for-python#6422

Closed

AutorestCI mentioned this pull request Jul 20, 2019

[AutoPR compute/resource-manager] Add terminate profile and scheduled events profile to Microsoft.Compute Azure/azure-sdk-for-go#5310

Merged

azuresdkci assigned amarzavery Jul 20, 2019

azuresdkci requested a review from amarzavery July 20, 2019 01:10

nschonni reviewed Jul 20, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Outdated Show resolved Hide resolved

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Outdated Show resolved Hide resolved

Update specification/compute/resource-manager/Microsoft.Compute/stabl…

a7b448e

…e/2019-03-01/compute.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

hyonholee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 24, 2019

szimmer-dev and others added 2 commits July 24, 2019 15:21

Update specification/compute/resource-manager/Microsoft.Compute/stabl…

d99620f

…e/2019-03-01/compute.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Add ScheduledEventsProfile to the UpdateVMScaleSetVM model, and add i…

722acaf

…nstance view expansion to get VM Scale Set VM.

Merge branch 'master' into dev/szimmer/AddTerminateProfile

49bbc92

amarzavery suggested changes Jul 30, 2019

View reviewed changes

szimmer-dev added 3 commits July 31, 2019 11:14

Add an example for terminate scheduled events, and add type:object to…

edd04f8

… scheudled events and termiante profile schemas.

Add example reference into compute.json

19a6129

Fix example file naming.

37f3208

Fix terminate scheduled event reference.

84963d0

amarzavery approved these changes Jul 31, 2019

View reviewed changes

hyonholee approved these changes Jul 31, 2019

View reviewed changes

majastrz reviewed Aug 1, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved

majastrz reviewed Aug 1, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved

majastrz added the ARMReviewInProgress label Aug 1, 2019

majastrz reviewed Aug 1, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 1, 2019

majastrz approved these changes Aug 1, 2019

View reviewed changes

amarzavery merged commit ab88105 into Azure:master Aug 1, 2019

szimmer-dev mentioned this pull request Aug 2, 2019

Generate new compute import for SDK Azure/azure-sdk-for-net#7087

Merged

szimmer-dev mentioned this pull request Sep 4, 2019

Add expand:instanceView for GET VMScaleSetVM Azure/azure-cli#10136

Open

Conversation

szimmer-dev commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 84963d0, Iteration 12)

Uh oh!

AutorestCI commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Jul 20, 2019

Uh oh!

nschonni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amarzavery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szimmer-dev commented Jul 31, 2019

Uh oh!

hyonholee commented Jul 31, 2019

Uh oh!

Uh oh!

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

szimmer-dev commented Jul 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2019 •

edited

Loading

AutorestCI commented Jul 20, 2019 •

edited

Loading

AutorestCI commented Jul 20, 2019 •

edited

Loading

AutorestCI commented Jul 20, 2019 •

edited

Loading